Fix default wait_for when port_bindings are specified#90
Closed
mchwalek wants to merge 2 commits intotestcontainers:mainfrom
Closed
Fix default wait_for when port_bindings are specified#90mchwalek wants to merge 2 commits intotestcontainers:mainfrom
mchwalek wants to merge 2 commits intotestcontainers:mainfrom
Conversation
mchwalek
commented
Oct 7, 2025
mchwalek
commented
Oct 7, 2025
| @database = database || ENV.fetch("POSTGRES_DATABASE", POSTGRES_DEFAULT_DATABASE) | ||
| @healthcheck ||= add_healthcheck(_default_healthcheck_options) | ||
| @wait_for ||= add_wait_for(:healthcheck) | ||
| @wait_for = add_wait_for(:healthcheck) if !@wait_for || !kwargs[:wait_for] |
Contributor
Author
There was a problem hiding this comment.
I'm wondering whether I should get the param from kwargs or just specify it in the constructor
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89